Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @dashpole (David Ashpole) as a maintainer #4830

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

MadVikingGod
Copy link
Contributor

@MadVikingGod MadVikingGod commented Jan 16, 2024

Requirements

  • Deep understanding of the technical goals and direction of the project
  • Deep understanding of the technical domain (specifically the language) of the project
  • Sustained contributions to design and direction
  • Sign-off by all existing maintainers

Follow up tasks

CONTRIBUTING.md Outdated Show resolved Hide resolved
@MadVikingGod MadVikingGod added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 16, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (279c549) 82.3% compared to head (3e191a9) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4830     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        226     226             
  Lines      18421   18421             
=======================================
- Hits       15166   15164      -2     
- Misses      2969    2971      +2     
  Partials     286     286             

see 1 file with indirect coverage changes

@MadVikingGod MadVikingGod merged commit cf93d0d into open-telemetry:main Jan 17, 2024
25 checks passed
@MadVikingGod MadVikingGod deleted the mvg/maintainer branch January 17, 2024 22:30
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants