Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease v1.10.0 #3158

Merged
merged 10 commits into from
Sep 12, 2022
Merged

Conversation

MadVikingGod
Copy link
Contributor

A step in #3157

Releases https://github.com/open-telemetry/opentelemetry-go/milestone/26

Added

Changed

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #3158 (48c21c2) into main (49a6536) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3158   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        180     180           
  Lines      12009   12009           
=====================================
  Hits        9169    9169           
  Misses      2598    2598           
  Partials     242     242           
Impacted Files Coverage Δ
version.go 100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MrAlias
Copy link
Contributor

MrAlias commented Sep 9, 2022

The exponential histogram mapping functions have been updated with
exact upper-inclusive boundary support following the corresponding
specification change. (Change the inclusivity of exponential histogram bounds #2982)

This is not included in this release and needs to be removed from the changelog entry.

@jmacd
Copy link
Contributor

jmacd commented Sep 9, 2022

This is not included in this release and needs to be removed from the changelog entry.

What happened to this change? I've been waiting to refer to it from opentelemetry-collector, here: open-telemetry/opentelemetry-collector#5938

@jmacd
Copy link
Contributor

jmacd commented Sep 9, 2022

I'd like to suggest we include the exponential histogram mapping function change in this release,
#3159

@MadVikingGod
Copy link
Contributor Author

@MrAlias Did I miss something? Maybe this needs to be a v1.10, and metrics/v0.32. release?

@MadVikingGod MadVikingGod changed the title Prerelease v1.10.0 Prerelease v1.10.0/v0.32.0 Sep 9, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Sep 9, 2022

@MrAlias Did I miss something? Maybe this needs to be a v1.10, and metrics/v0.32. release?

We had agreed the next metric release is going to be for the alpha SDK. I think the versioning is correct as is.

This is not included in this release and needs to be removed from the changelog entry.

What happened to this change? I've been waiting to refer to it from opentelemetry-collector, here: open-telemetry/opentelemetry-collector#5938

I thought it was agreed the commit hash version of main would be used as a dependency for this package?

@jmacd
Copy link
Contributor

jmacd commented Sep 9, 2022

I thought it was agreed the commit hash version of main would be used as a dependency for this package?

I can do that. I've done that in otel-launcher-go but I don't feel comfortable doing that for the OTel collector. I proposed #3159 because it seems to avoid leaving clutter in the sdk/metric/aggregator package where the new SDK doesn't want it to belong, it's fine to let this go to another release.

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if #3156 could be included in this release, approved either way.

@jmacd
Copy link
Contributor

jmacd commented Sep 9, 2022

@MadVikingGod sorry to create trouble. I think it's OK not to create a v0.32 metrics release, especially if we can prioritize moving the sdk/metric/aggregator/exponential support into a new location to be included in the next 1.x release.

Revert "Merge branches 'prerelease_experimental-metrics_v0.32.0' and 'prerelease_bridge_v0.32.0' into prerelease-v1.10.0"

This reverts commit 8341bbf, reversing
changes made to 75227ae.

Revert "Prepare bridge for version v0.32.0"

This reverts commit 5b20a30.

Revert "Prepare experimental-metrics for version v0.32.0"

This reverts commit 75227ae.
@MadVikingGod MadVikingGod changed the title Prerelease v1.10.0/v0.32.0 Prerelease v1.10.0 Sep 9, 2022
@MadVikingGod
Copy link
Contributor Author

I don't remember the v0.32 discussion, but I'm fine with that.

I have reverted the changes for those versions (v0.32.0), and have removed the changelog entry.

@MadVikingGod
Copy link
Contributor Author

As #3156 is also a customer impacting bugfix I also would like to see that in this release. I will delay until that is landed in main, and can be added to this PR.

CHANGELOG.md Show resolved Hide resolved
@MadVikingGod MadVikingGod merged commit 0e6f9c2 into open-telemetry:main Sep 12, 2022
@MadVikingGod MadVikingGod deleted the prerelease-v1.10.0 branch September 12, 2022 20:19
@MadVikingGod MadVikingGod mentioned this pull request Sep 13, 2022
10 tasks
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants