Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCensus bridge should return structs #4570

Closed
dashpole opened this issue Sep 29, 2023 · 1 comment · Fixed by #4583
Closed

OpenCensus bridge should return structs #4570

dashpole opened this issue Sep 29, 2023 · 1 comment · Fixed by #4583
Labels
enhancement New feature or request pkg:bridges Related to a bridge package

Comments

@dashpole
Copy link
Contributor

Problem Statement

Similar to #4243, we should return a struct from NewMetricProducer instead of the metric.Producer interface:

https://github.com/open-telemetry/opentelemetry-go/blob/main/bridge/opencensus/metric.go#L37

After #4567, we won't return an interface for the trace bridge: https://github.com/open-telemetry/opentelemetry-go/pull/4567/files#diff-ee40e63756bf77fde5a66bcf047e3bee7ae65207d633d2a4dc9139a8b7d6362fR38

Proposed Solution

Return a public struct instead of the metric.Producer interface.
@dashpole dashpole added enhancement New feature or request pkg:bridges Related to a bridge package labels Sep 29, 2023
@dashpole dashpole mentioned this issue Oct 3, 2023
Merged
@dashpole
Copy link
Contributor Author

dashpole commented Oct 9, 2023

Fixed by #4583

@dashpole dashpole closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
No milestone
1 participant
@dashpole