Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: TestBatchSpanProcessorForceFlushCancellation #4197

Closed
pellared opened this issue Jun 5, 2023 · 2 comments
Closed

Flaky test: TestBatchSpanProcessorForceFlushCancellation #4197

pellared opened this issue Jun 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@pellared
Copy link
Member

pellared commented Jun 5, 2023

https://github.com/open-telemetry/opentelemetry-go/actions/runs/5174510036/jobs/9320908218?pr=4154

--- FAIL: TestBatchSpanProcessorForceFlushCancellation (0.00s)
    batch_span_processor_test.go:571: expected "context canceled" error, got <nil>
@pellared pellared added the bug Something isn't working label Jun 5, 2023
@tonisanta
Copy link

Hello @pellared I had a quick look at this issue but with yours changes in this PR I would say this issue should be also solved! If not, feel free to provide any extra info and I'll try to help.

@pellared
Copy link
Member Author

pellared commented Sep 7, 2023

It looks that you are right. Closing. Thank you.

@pellared pellared closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pellared @tonisanta