Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deinal of metric collection via adversiral callback registration. #3741

Open
MadVikingGod opened this issue Feb 17, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@MadVikingGod
Copy link
Contributor

Description

If there is an error reported in any callback function no

Environment

tested with, but should apply to all

  • OS: linx
  • Architecture: amd64
  • Go Version: 1.19.4
  • opentelemetry-go version: v1.13.0/v.0.36.0

Steps To Reproduce

The example provided has two different "libraries" one for single callback and another for multicallback. Both only return an error. This behavior will happen for any callback that errors.

  1. clone example project: https://github.com/MadVikingGod/adversirial-callback
  2. run, this should have a populated Resource Metric printed
  3. uncomment either import
  4. run, This won't have any metrics printed.

Expected behavior

In the example above importing a callback which errors should not prevent other metrics from being reported.

@MadVikingGod MadVikingGod added the bug Something isn't working label Feb 17, 2023
@unicod3
Copy link
Contributor

unicod3 commented Mar 1, 2023

Hey @MadVikingGod

I can't reproduce this with v1.14.0/v.0.37.0

It seems this has been resolved already with PR #3732

But I can work on it if we still want to patch version v1.13.0/v.0.36.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants