Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make precommit fails, complains about build-tools/dbotconf #3680

Open
yurishkuro opened this issue Feb 5, 2023 · 3 comments
Open

make precommit fails, complains about build-tools/dbotconf #3680

yurishkuro opened this issue Feb 5, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@yurishkuro
Copy link
Member

Description

Running make precommit fails with:

$ make precommit
cd ./internal/tools && \
	go build -o /Users/ysh/dev/otel/opentelemetry-go/.tools/dbotconf go.opentelemetry.io/build-tools/dbotconf
no required module provides package go.opentelemetry.io/build-tools/dbotconf; to add it:
	go get go.opentelemetry.io/build-tools/dbotconf
make: *** [~/dev/otel/opentelemetry-go/.tools/dbotconf] Error 1

Trying to follow the suggested resolution also fails:

$ (cd ./internal/tools; \
        go build -o /Users/ysh/dev/otel/opentelemetry-go/.tools/dbotconf go.opentelemetry.io/build-tools/dbotconf )
no required module provides package go.opentelemetry.io/build-tools/dbotconf; to add it:
	go get go.opentelemetry.io/build-tools/dbotconf

Environment

  • OS: masOS 13.1
  • Go Version: 1.19
  • opentelemetry-go version: 1.12.0

Additional comments

I would recommend changing the help text to (cd dir && cmd2) instead of cd dir && cmd2, because the former leaves the workind dir unchanged regardless of the outcome.

@yurishkuro yurishkuro added the bug Something isn't working label Feb 5, 2023
@sumit1606
Copy link

@yurishkuro May I work on this ? If it still needs help ?

@yurishkuro
Copy link
Member Author

fell free

@sumit1606
Copy link

fell free

Do you mind assigning it to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants