Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics SDK default label encoding not unique #332

Closed
lzchen opened this issue Nov 19, 2019 · 3 comments · Fixed by #508
Closed

Metrics SDK default label encoding not unique #332

lzchen opened this issue Nov 19, 2019 · 3 comments · Fixed by #508
Assignees
@jmacd
Labels
area:metrics Part of OpenTelemetry Metrics

Comments

@lzchen
Copy link

lzchen commented Nov 19, 2019

Looking at the current implementation of the default label encoder, will this produce unique encodings with get_label_set({"foo=bar": "baz"}) and get_label_set({"foo": "bar=baz"})? Are we restricting users from have '=' in their labelkeys/values? Sorry if I am misunderstanding as my Go is not as strong :).
@lzchen lzchen mentioned this issue Nov 19, 2019
Merged
@jmacd
Copy link
Contributor

jmacd commented Nov 19, 2019

This is a legitimate issue. I'll add this to the list of things that need to be cleared up.

@jmacd
Copy link
Contributor

jmacd commented Nov 19, 2019

I think we should restrict keys not to contain certain characters, yes, but some kind of escaping will still be needed. On that topic, there are still open questions about whether unspecified values need to be treated differently from empty-string values, which will touch on the same issue.

@rghetia rghetia added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Dec 5, 2019
@jmacd
Copy link
Contributor

jmacd commented Dec 9, 2019

Note DataDog/datadog-go#83

@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Dec 12, 2019
@andrewhsu andrewhsu mentioned this issue Mar 3, 2020
Closed
@jmacd jmacd self-assigned this Mar 4, 2020
@jmacd jmacd removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Mar 4, 2020
@jmacd jmacd mentioned this issue Mar 4, 2020
Merged
@jmacd jmacd closed this as completed in #508 Mar 4, 2020
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@dependabot @MrAlias
Bump github.com/spf13/afero from 1.3.4 to 1.3.5 in /exporters/metric/…
9a032d8 
…cortex/utils (#332)

* Bump github.com/spf13/afero in /exporters/metric/cortex/utils

Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.3.4 to 1.3.5.
- [Release notes](https://github.com/spf13/afero/releases)
- [Commits](spf13/afero@v1.3.4...v1.3.5)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the default label encoding unique jmacd/opentelemetry-go
3 participants
@jmacd @rghetia @lzchen