Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if the Aggregator API should handle attributes #3030

Closed
2 tasks
MrAlias opened this issue Jul 19, 2022 · 2 comments
Closed
2 tasks

Investigate if the Aggregator API should handle attributes #3030

MrAlias opened this issue Jul 19, 2022 · 2 comments
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 19, 2022

It looks like there's a lot of logic baked into the Sum aggregator that could be treated at at higher level in the SDK, to me. I'm referring mostly to the appearance of a map[attribute.Set]N inside this type, whereas a map could be managed independently of the specific aggregation in use. When it comes to managing synchronization of removing stale entries from these maps, the logic ought to be identical across aggregators, I figure. For this reason, I was expecting to see a type that represents either an integer sum or a floating point sum, but not a type that represents a map of values, in this PR.

Originally posted by @jmacd in #3000 (comment)

  • Determine if there are enough similarities to abstract the mapping of aggregations to attributes across all aggregators to abstract into a higher level of the SDK.
  • Implement finding with the optimal solution.
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jul 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Jul 19, 2022
@MadVikingGod
Copy link
Contributor

Related to #3006

@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 20, 2022
This was referenced Oct 27, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 18, 2024

We no longer plan to do this.

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
Development

No branches or pull requests

2 participants