Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the OTEL_BSP_* environment variables #2306

Closed
MrAlias opened this issue Oct 19, 2021 · 5 comments · Fixed by #2515
Closed

Support the OTEL_BSP_* environment variables #2306

MrAlias opened this issue Oct 19, 2021 · 5 comments · Fixed by #2515
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Oct 19, 2021

Add support for the following environment variables as defined in the specification.

  • OTEL_BSP_SCHEDULE_DELAY
  • OTEL_BSP_EXPORT_TIMEOUT
  • OTEL_BSP_MAX_QUEUE_SIZE
  • OTEL_BSP_MAX_EXPORT_BATCH_SIZE

Part of #1698

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing labels Oct 19, 2021
@hanyuancheung
Copy link
Member

This is already done: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/trace/batch_span_processor.go#L29-L32, I'll change the status of otel-specification.

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 29, 2021

The link provided is to code that defines defaults for the batch span processor, not parsing of the listed environment variables. A search of the project also does not return any use of the mentioned variables names. It does not appear that this is complete.

@ianzhang1988
Copy link

Can someone elaborate how actually these OTEL_BSP_* work.

In my test, It show that at every OTEL_BSP_EXPORT_TIMEOUT sdk send OTEL_BSP_MAX_EXPORT_BATCH_SIZE spans. Then some spans got droped(I guess it used up OTEL_BSP_MAX_QUEUE_SIZE).

Is OTEL_BSP_EXPORT_TIMEOUT interval for sending spans?

@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 2, 2022

@ianzhang1988 please take a look at the related batch span processor docs (https://pkg.go.dev/go.opentelemetry.io/otel/sdk/trace#BatchSpanProcessorOption) and the specification info on the environment variables (https://github.com/open-telemetry/opentelemetry-specification/blob/08a15efd4c43336ae31d14809aaa1acce07c9a0a/specification/sdk-environment-variables.md#batch-span-processor).

If these do not answer your question, please open an new issue for your question.

@ianzhang1988
Copy link

@MrAlias After some digging, I found that It's my server end (jaeger) do not send http 202, then block otel upload. Sorry for the false alarm.

@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants