-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate semconv package for 1.4.0 #1975
Comments
We should also document this process and decide on open-telemetry/opentelemetry-collector#2600 |
It is partially documented here https://github.com/open-telemetry/opentelemetry-go/blob/main/RELEASING.md#semantic-convention-generation but only says how to generate trace.go and resource.go. |
Ah, gotcha. I missed that 👍 |
@tigrannajaryan I think the |
Interesting, I must have misunderstood the generation gap for these files then. @Aneurysm9 is going to have a lot more context here. |
Those are generated into |
So do we just copy existing http.go and exeception.go and we should be good? |
Yeah, that's what I'm going to do. I'll have a PR up shortly. |
Now that spec 1.4.0 is release we need to generate semconv 1.4.0 and update SDK's resource detectors to use it.
I can generate semconv/trace.go and semconv/resources.go using the generator but I don't know how to generate semconv/http.go, exception.go, etc.
@MrAlias @Aneurysm9 can you help?
The text was updated successfully, but these errors were encountered: