From 77de1998cf5364262e06527157be49aba8d3e7a3 Mon Sep 17 00:00:00 2001 From: Matej Gera <38492574+matej-g@users.noreply.github.com> Date: Sun, 13 Sep 2020 20:45:46 +0200 Subject: [PATCH] Minor change: ParentSampler -> ParentBased in Zipkin example description (#1171) * ParentSampler -> ParentBased in Zipkin example description * update CHANGELOG --- CHANGELOG.md | 4 ++++ example/zipkin/main.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bc5a7c89b8..aa0d509526d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm recommend the use of `newConfig()` instead of `configure()`. (#1163) - The `otlp.Config` type has been unexported and changed to `otlp.config`, along with its initializer. (#1163) +### Fixed + +- Zipkin example no longer mentions `ParentSampler`, corrected to `ParentBased`. (#1171) + ## [0.11.0] - 2020-08-24 ### Added diff --git a/example/zipkin/main.go b/example/zipkin/main.go index a331de81c00..ef583dba2d6 100644 --- a/example/zipkin/main.go +++ b/example/zipkin/main.go @@ -36,7 +36,7 @@ func initTracer(url string) { // Create Zipkin Exporter and install it as a global tracer. // // For demoing purposes, always sample. In a production application, you should - // configure the sampler to a trace.ParentSampler(trace.TraceIDRatioBased) set at the desired + // configure the sampler to a trace.ParentBased(trace.TraceIDRatioBased) set at the desired // ratio. err := zipkin.InstallNewPipeline( url,