Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pkg and test to internal and deprecate original #282

Merged
merged 10 commits into from
Sep 7, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 6, 2023

Part of #270; this moves code that does not need to be exported into the internal package.

  • Copy existing pkg and test packages into internal package
  • Deprecate existing pkg and test packages and modules.
  • Update tooling to use new package

@MrAlias MrAlias changed the title Move pkg and test to internal Copy pkg and test to internal and deprecate original Sep 6, 2023
@edeNFed
Copy link
Contributor

edeNFed commented Sep 6, 2023

@MrAlias can we leave a few APIs in the pkg directory? We are using the Go auto instrumentation as a library and moving everything to internal will break our code: https://github.com/keyval-dev/odigos/blob/main/odiglet/pkg/ebpf/objects.go

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 6, 2023

@MrAlias can we leave a few APIs in the pkg directory? We are using the Go auto instrumentation as a library and moving everything to internal will break our code: https://github.com/keyval-dev/odigos/blob/main/odiglet/pkg/ebpf/objects.go

Sure, I'll take a look and update.

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 6, 2023

@edeNFed it seems like you are already working with a fork of this project: https://github.com/keyval-dev/odigos/blob/acf1ec5daa52fb56a551ee47ef22bb0515e1ddad/odiglet/go.mod#L98. I'm not able to find things like NewControllerWithServiceName in the existing packages.

This makes me think that we need to work on our API so these kinds of workarounds are not needed. I have thoughts on a revised and simpiler API, but don't want to make that proposal in this PR. What do you think about keeping this PR as is, tracking the revised API design in a new issue, and adding the API to the top-level go.opentelemetry.io/auto package?

@edeNFed
Copy link
Contributor

edeNFed commented Sep 6, 2023

Sure sounds great

@MrAlias MrAlias marked this pull request as ready for review September 6, 2023 20:53
@MrAlias MrAlias requested a review from a team September 6, 2023 20:53
@MrAlias MrAlias added this to the v0.3.0-alpha milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants