Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the inject_header function, fix bug in net/http server instru… #266

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Enhance the inject_header function, fix bug in net/http server instru… #266

merged 9 commits into from
Oct 2, 2023

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Aug 23, 2023

  • Fix bug in net/http server instrumentation in which the span context was always generated as a random string rather than taking the parent one if exists
  • Enhance the inject header function to be more readable

@RonFed RonFed marked this pull request as ready for review August 23, 2023 21:10
@RonFed RonFed requested a review from a team August 23, 2023 21:10
@RonFed
Copy link
Contributor Author

RonFed commented Aug 26, 2023

@oxeye-gal Can you please have a look on the changes made to the inject_headers function ?

@MrAlias
Copy link
Contributor

MrAlias commented Sep 13, 2023

Please rebase these changes into internal/pkg (changed in #282). The pkg directory is going to be removed in #302 given that package is no longer used.

@RonFed RonFed force-pushed the improve_http_header_injection branch from 05a0fb2 to 63a7b14 Compare September 20, 2023 13:26
@RonFed
Copy link
Contributor Author

RonFed commented Sep 20, 2023

Please rebase these changes into internal/pkg (changed in #282). The pkg directory is going to be removed in #302 given that package is no longer used.

Rebased

MrAlias
MrAlias reviewed Sep 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
internal/include/go_types.h Outdated Show resolved Hide resolved
internal/include/go_types.h Outdated Show resolved Hide resolved
internal/include/go_types.h Outdated Show resolved Hide resolved
@MrAlias
Copy link
Contributor

MrAlias commented Sep 26, 2023

@edeNFed @MikeGoldsmith: please take another look

@edeNFed edeNFed merged commit 3661887 into open-telemetry:main Oct 2, 2023
13 checks passed
@RonFed RonFed mentioned this pull request Oct 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeNFed edeNFed edeNFed approved these changes

@MrAlias MrAlias MrAlias approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RonFed @MrAlias @MikeGoldsmith @edeNFed