[net/http] add http.server.active_requests metric #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
suggested changes
Aug 1, 2022
| @@ -201,12 +205,15 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| labeler := &Labeler{} | |||
| ctx = injectLabeler(ctx, labeler) | |||
|
|
|||
| // Add metrics | |||
| attributes := append(labeler.Get(), semconv.HTTPServerMetricAttributesFromHTTPRequest(h.operation, r)...) | |||
There was a problem hiding this comment.
This breaks the use of Labeler to allow handlers to add labels to the instrumentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziqi Zhao zhaoziqi9146@gmail.com
Enhance instrumentation library otelhttp for
net/httpto satisfy opentelemetry http server metric semantic conventions.This PR added missed metric
http.server.active_requestsfor server