Make the otelhttp Transport handle protocol switching #1628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1329
The
otelhttp.Transport
type wraps the response body returned from the HTTP request. Response bodies from requests to protocol switch (e.g. WebSockets, h2c) will contain a writable response body implementing theio.ReadWriteCloser
interface. This interface needs to continue being satisfied so these new protocols can write directly to the opened TCP socket. This changes thewrappedBody
type to implement anio.ReadWriteCloser
and appropriately scopes the response body implementation to match the original (removing theWrite
method of thewrappedBody
when it is not supported).