Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spans created by HTTP instrumentation package does not conform to guidelines for span names #726

Open
YuriiBarninets opened this issue Mar 31, 2021 · 3 comments

Comments

@YuriiBarninets
Copy link

According to the OpenTelemetry specification HTTP spans MUST follow the overall guidelines for span names.

For example, the current implementation of HTTP instrumentation package creates Spans with the name GET or POST, even though the specification says that HTTP {METHOD_NAME} should be used as Span name.

HTTP client spans SHOULD be using conservative, low cardinality names formed from the available parameters of an HTTP request, such as "HTTP {METHOD_NAME}"

@humivo
Copy link
Member

humivo commented Apr 20, 2021

Hey can I try to do this one?

@dashpole
Copy link
Contributor

For server spans, it would be nice to include the route as well, as described in the spec.

(Inspired by kubernetes/kubernetes#112059)

@dashpole
Copy link
Contributor

cc @fatsheep9146

It would be nice if the default behavior of otelhttp matched what you are doing in k8s so we don't need to implement our own naming function there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants