Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelmongo] bump semconv to 1.26.0 #6171

Closed
prestonvasquez opened this issue Oct 1, 2024 · 1 comment
Closed

[otelmongo] bump semconv to 1.26.0 #6171

prestonvasquez opened this issue Oct 1, 2024 · 1 comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelmongo

Comments

@prestonvasquez
Copy link
Contributor

prestonvasquez commented Oct 1, 2024

Problem Statement

otelmongo is currently using semconv/v1.17.0, suggest updating to semconv/v1.26.0.

Proposed Solution

key/value pair changes migrating from 1.17.0 to 1.26.0 include:

Old Func New Func Old Key New Key Notes
DBOperation DBOperationName db.operation db.operation.name
DBName DBNamespace db.name db.namespace
NetPeerName NetworkPeerAddress net.peer.name network.peer.address Currently the hostname is used for the peer name. Documentation suggest using the server address.
NetPeerPort NetworkPeerPort net.peer.port network.peer.port
NetTransportTCP NetworkingTransportTCP net.transport network.transport Network transport no longer includes the ip_ portion defined on the deprecated net.trasnport. Instead, this value is either tcp or udp.
DBStatement DBQueryText db.statement db.query.text There is no deprecated analogue to `db.statement` according to the documentation. Db.query.text seemed like a natural fit.

Alternatives

Since these fields are deprecated, there is no alternative other than leaving the semconv version static.

Prior Art

NA

Additional Context

It's worth noting that this is a breaking change if telemetry key/values are considered stable.

@prestonvasquez prestonvasquez added area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelmongo labels Oct 1, 2024
@prestonvasquez prestonvasquez changed the title Bump semconv to 1.26.0 [otelmongo] bump semconv to 1.26.0 Oct 1, 2024
@prestonvasquez
Copy link
Contributor Author

prestonvasquez commented Oct 22, 2024

A major version release of otelmongo should be planned before bumping to 1.26.0: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/versioning-and-stability.md#semantic-conventions-stability

OTEL_SEMCONV_STABILITY_OPT_IN is not intended for already stable releases, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelmongo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant