Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard gRPC metrics as per proposal A66 #6093

Open
dhowden opened this issue Sep 6, 2024 · 0 comments
Open

Support standard gRPC metrics as per proposal A66 #6093

dhowden opened this issue Sep 6, 2024 · 0 comments
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc

Comments

@dhowden
Copy link

dhowden commented Sep 6, 2024

Problem Statement

There is a gRPC proposal for standardising OpenTelemetry metrics (A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md) linked from here: https://grpc.io/docs/guides/opentelemetry-metrics/#server-instruments.

The recommended gRPC integration (go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.ServerHandler) does not follow this standard:

  • similar metrics, but with small differences in naming (rpc, not grpc).
  • completely missing "call.started" count.

Proposed Solution

Implement the metrics proposed in A66.

Alternative Solution

Document the code to detail that it follows some other standard (and point to that).

@dhowden dhowden added area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Projects
None yet
Development

No branches or pull requests

1 participant