Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish otelzerolog as it is not handling core functionality #5969

Closed
pellared opened this issue Aug 1, 2024 · 9 comments · Fixed by #5996
Closed

Do not publish otelzerolog as it is not handling core functionality #5969

pellared opened this issue Aug 1, 2024 · 9 comments · Fixed by #5996
Assignees
Labels
bridge: zerolog Related to the zerolog bridge bug Something isn't working
Milestone

Comments

@pellared
Copy link
Member

pellared commented Aug 1, 2024

This Issue originates from a SIG discussion around #5963 (comment) on 2024-08-01.

With otelzerolog bridge not being able transform fields into attribute nor handle context correlation (because of rs/zerolog#493), we do not see value in publishing (and even maintaining) otelzerolog.

Can we move this module to a separate repository until rs/zerolog#493 is solved?

CC @dmathieu @AkhigbeEromo

@pellared pellared added bug Something isn't working bridge: zerolog Related to the zerolog bridge labels Aug 1, 2024
@dmathieu
Copy link
Member

dmathieu commented Aug 2, 2024

Seeing both those issues have been open for 2+ years, we can't expect a quick resolution.
So not having a zerolog bridge if we don't have those features makes sense.

I am a codeowner of that bridge because I helped @AkhigbeEromo set up the bridge. But I don't have any vested interest in that bridge, so I'm not particularly keen on owning that separate repository.
@AkhigbeEromo if you wish to take that, please feel free to do so.

@AkhigbeEromo
Copy link
Contributor

I will like to take it

@MrAlias MrAlias added this to the v1.29.0 milestone Aug 7, 2024
@pellared
Copy link
Member Author

pellared commented Aug 8, 2024

@AkhigbeEromo, I assigned it to you. Please create a PR that removes the otelzerolog and share with us where you are migrating it. After the migration you can add it to the OTel Registry. So far I created a PR to remove otelzerolog from OTel Registry: open-telemetry/opentelemetry.io#4932

@MrAlias
Copy link
Contributor

MrAlias commented Aug 8, 2024

@pellared is going to create a PR to just remove this. The clone of this can reference the history of the repository to make the copy.

@pellared
Copy link
Member Author

pellared commented Aug 8, 2024

@AkhigbeEromo I created #5996 as it is blocking the next release of OTel Go. Still, feel free to move the code to a fork and add it to the OTel Registry. Please make sure to keep the "license header" in the files to not violate the licensing.

@AkhigbeEromo
Copy link
Contributor

Hello @pellared
How do I add the code to Otel registry

@pellared
Copy link
Member Author

pellared commented Aug 8, 2024

The reverse of open-telemetry/opentelemetry.io#4932

@AkhigbeEromo
Copy link
Contributor

AkhigbeEromo commented Aug 9, 2024

I have the code on a branch of my fork of the repo,
Just to clarify, when you say I should add the code to Otel registry
I should send in a PR doing the opposite of what you did to the Opentelemetry.io repo?

@pellared
Copy link
Member Author

pellared commented Aug 9, 2024

Calling it "fork" was not precise. I mean move this module to a separate repository e.g. https://github.com/AkhigbeEromo/otelzerolog.

After you move the code, (configure some build pipeline), and publish a release, you can add it to the registry by summitting a PR in https://github.com/open-telemetry/opentelemetry.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: zerolog Related to the zerolog bridge bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants