Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Remove withoutContext #4703

Closed
pellared opened this issue Dec 15, 2023 · 2 comments · Fixed by #4705
Closed

otelgrpc: Remove withoutContext #4703

pellared opened this issue Dec 15, 2023 · 2 comments · Fixed by #4705
Assignees
@carrbs
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Milestone
v0.47.0

Comments

@pellared
Copy link
Member

pellared commented Dec 15, 2023 •
edited
Loading

With open-telemetry/opentelemetry-go#4671 the withoutContext implementation is no longer needed.

This issue awaits a new release of OTel Go SDK where the mentioned PR will be included.

This issue is nice to have in v0.47.0
but it can be moved to next release.
@pellared pellared added enhancement New feature or request area: instrumentation Related to an instrumentation package instrumentation: otelhttp labels Dec 15, 2023
@pellared pellared changed the title otelhttp: otelhttp: Remove withoutContext Dec 15, 2023
@pellared
Copy link
Member Author

CC @carrbs

@pellared pellared added this to the v0.48.0 milestone Dec 15, 2023
@pellared pellared modified the milestones: v0.48.0, v0.47.0 Dec 15, 2023
@pellared pellared changed the title otelhttp: Remove withoutContext otelgrpc: Remove withoutContext Dec 15, 2023
@carrbs carrbs mentioned this issue Dec 16, 2023
Merged
@carrbs
Copy link
Contributor

carrbs commented Dec 27, 2023

@pellared, should I be assigned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carrbs carrbs

Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Projects
None yet
Milestone
v0.47.0
Development

Successfully merging a pull request may close this issue.

otelgrpc: Remove withoutContext carrbs/opentelemetry-go-contrib
2 participants
@carrbs @pellared