Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Add Instrumentation for otelhttp #2481

Open
10 tasks
jeremyje opened this issue Jul 2, 2022 · 0 comments
Open
10 tasks

Request to Add Instrumentation for otelhttp #2481

jeremyje opened this issue Jul 2, 2022 · 0 comments
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelhttp

Comments

@jeremyje
Copy link

jeremyje commented Jul 2, 2022

Background

Package Link: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Add instrumentation and tracing to net/http

Why can this instrumentation not be included in the package itself?

No it's part of the go standard library

Why can this instrumentation not be hosted in a dedicated repository?

Proposed Solution

Use the RequestCount metric already defined in otelhttp.

Tracing

  • attributes:
  • events:
  • links:

Metrics

Instruments

  • :
    • type:
    • unit:
    • description:
    • attributes:

Prior Art

Tasks

  • Code complete:
    • Comprehensive unit tests.
    • End-to-end integration tests.
    • Tests all passing.
    • Instrumentation functionality verified.
  • Documented
  • Examples
    • Dockerfile file to build example application.
    • docker-compose.yml to run example in a docker environment to demonstrate instrumentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelhttp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants