Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance issues] use grpc metadata FromOutgoingContext function #1031

Open
AtlanCI opened this issue Aug 27, 2021 · 1 comment
Open

[Performance issues] use grpc metadata FromOutgoingContext function #1031

AtlanCI opened this issue Aug 27, 2021 · 1 comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc

Comments

@AtlanCI
Copy link

AtlanCI commented Aug 27, 2021

Background

grpc version 1.39 and 1.37
Package Link:
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go

StreamClientInterceptor and UnaryClientInterceptor

Proposed Solution

The fromoutgoingcontext implementation in grpc versions 1.39 and 1.37 is different. In 1.37, it parses CTX using the join function. Whether the appendtooutgoingcontext function should be used in opentelemetry.

@AtlanCI AtlanCI added area: instrumentation Related to an instrumentation package enhancement New feature or request release:after-ga labels Aug 27, 2021
@AtlanCI
Copy link
Author

AtlanCI commented Aug 27, 2021

260b6c46df5f5bfe06f595d82c47719
Replace with this function fromoutgoingcontext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Projects
None yet
Development

No branches or pull requests

2 participants