Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default output of chloggen to stdout #612

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 6, 2024

Fixes #611

This PR sets the default output for chloggen to stdout as it would be set to stderr otherwise which has all kinds of issues that follow in the usage of the tool downstream.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies requested review from a team as code owners November 6, 2024 09:43
@mowies mowies requested a review from songy23 November 6, 2024 09:43
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.17%. Comparing base (8865664) to head (84e79fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   51.16%   51.17%   +0.01%     
==========================================
  Files          51       51              
  Lines        2881     2882       +1     
==========================================
+ Hits         1474     1475       +1     
  Misses       1260     1260              
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
Copy link
Member Author

mowies commented Nov 6, 2024

markdown-link-check is failing because of a regression on their side, nothing that can be fixed here.

dmathieu
dmathieu approved these changes Nov 6, 2024
@dmathieu
Copy link
Member

dmathieu commented Nov 6, 2024

See #613 for the markdown-lint-check issue.

@mx-psi mx-psi merged commit d417b09 into open-telemetry:main Nov 6, 2024
12 checks passed
@mowies mowies deleted the fix-chloggen-output branch November 6, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chloggen prints all output to stdout by default
4 participants