Add gotmpl tool #280
Merged
Add gotmpl tool #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 58.95% 58.99% +0.03%
==========================================
Files 44 46 +2
Lines 1988 2024 +36
==========================================
+ Hits 1172 1194 +22
- Misses 686 698 +12
- Partials 130 132 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MrAlias
reviewed
Mar 22, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dmathieu
reviewed
Mar 29, 2023
dmathieu
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follows #275 (next iteration)
Fixes #276
Towards addressing open-telemetry/opentelemetry-go#3846
Towards fixing open-telemetry/opentelemetry-go#3548
What
Add
gotmpltool that can be used withgo:generate.This tool is currently needed for https://github.com/open-telemetry/opentelemetry-go. See: open-telemetry/opentelemetry-go#3846. We want to use it automate sharing internal code (more in
README.md) without introducing a lot of manual code duplication.Other
Do we want to use it for
internal/repoandinternal/syncerror? Personally, I think there is no big need as these APIs looks pretty stable. And AFAIK the tools are bumped together. On the other hand, it may be good to dogfood for the sake of consistency across OTel Go repositories. Because I cannot find a clear answer myself, I can simply create a follow-up PR once this one is merged. It should be easier for the reviewers to decide.