Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #136

Open
tsloughter opened this issue Nov 2, 2020 · 6 comments
Open

Error handling #136

tsloughter opened this issue Nov 2, 2020 · 6 comments
Labels
help wanted Extra attention is needed language-elixir language-erlang scope-api scope-sdk spec A change to the SDK specification that must be implemented.
Milestone

Comments

@tsloughter
Copy link
Member

There are some details in the spec about error handling https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/error-handling.md

I think we may want to use telemetry to signal certain types of errors for the user to handle but I haven't looked at it closely enough to say for sure yet.

Thoughts?

@tsloughter tsloughter added help wanted Extra attention is needed language-elixir language-erlang scope-api scope-sdk spec A change to the SDK specification that must be implemented. labels Nov 2, 2020
@tsloughter tsloughter added this to the GA milestone Nov 2, 2020
@wingyplus
Copy link

Maybe we can use the logger backend to do such a thing?

@tsloughter
Copy link
Member Author

@wingyplus there is meant to be attachable error handlers, so I think telemetry fits. It could be optional and just log by default though.

@hauleth
Copy link
Member

hauleth commented Nov 16, 2020

If I understand the Java example correctly, then we can just use Erlang's logger and call it a day, as it supports all we need. Maybe with some helper functions for attaching the filters.

@wingyplus
Copy link

wingyplus commented Nov 17, 2020

@wingyplus there is meant to be attachable error handlers, so I think telemetry fits. It could be optional and just log by default though.

Sound interesting. I just thought that we already use logger, that would be easier to do this. And there is needs to add telemetry execution in the code before doing this if we want to go to telemetry way?

If I understand the Java example correctly, then we can just use Erlang's logger and call it a day, as it supports all we need. Maybe with some helper functions for attaching the filters.

If I understand correctly, we can add logger backend and trap error level and setting the filter on top of the backend.

@hauleth
Copy link
Member

hauleth commented Nov 17, 2020

If I understand correctly, we can add logger backend and trap error level and setting the filter on top of the backend.

Better, we can use domain filtering for that.

@tsloughter
Copy link
Member Author

I made a ticket for adding the domain to all logs: #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed language-elixir language-erlang scope-api scope-sdk spec A change to the SDK specification that must be implemented.
Projects
None yet
Development

No branches or pull requests

3 participants