Skip to content

Conversation

hannahhaering
Copy link
Contributor

@hannahhaering hannahhaering commented Oct 2, 2025

Fixes #5635

Changes

Reset scale to 20 of the Base2 Exponential Bucket Histogram after each collection cycle when using delta aggregation temporality.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@hannahhaering hannahhaering marked this pull request as ready for review October 2, 2025 02:35
@hannahhaering hannahhaering requested a review from a team as a code owner October 2, 2025 02:35
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (8b3d8fa) to head (fb421b9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6557      +/-   ##
==========================================
+ Coverage   86.38%   86.69%   +0.30%     
==========================================
  Files         258      258              
  Lines       11909    11910       +1     
==========================================
+ Hits        10288    10325      +37     
+ Misses       1621     1585      -36     
Flag Coverage Δ
unittests-Project-Experimental 86.61% <100.00%> (+0.26%) ⬆️
unittests-Project-Stable 86.53% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ics/MetricPoint/Base2ExponentialBucketHistogram.cs 100.00% <100.00%> (ø)
...c/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs 94.17% <100.00%> (-0.07%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Please update the CHANGELOG.

hannahhaering and others added 6 commits October 7, 2025 11:05
@Kielek Kielek requested a review from martincostello October 8, 2025 04:35
@Kielek Kielek merged commit ac8d45e into open-telemetry:main Oct 8, 2025
47 checks passed
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Thank you for your contribution @hannahhaering! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

This was referenced Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base2 Exponential Bucket Histogram should reset to scale 20 after each collection cycle if DELTA aggregation temporality is used

4 participants