-
Notifications
You must be signed in to change notification settings - Fork 848
Reset scale of exponential histogram #6557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset scale of exponential histogram #6557
Conversation
…m/hannahhaering/opentelemetry-dotnet into exponential-histogram-reset-scale
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6557 +/- ##
==========================================
+ Coverage 86.38% 86.69% +0.30%
==========================================
Files 258 258
Lines 11909 11910 +1
==========================================
+ Hits 10288 10325 +37
+ Misses 1621 1585 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. Please update the CHANGELOG.
src/OpenTelemetry/Metrics/MetricPoint/Base2ExponentialBucketHistogram.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
Thank you for your contribution @hannahhaering! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Fixes #5635
Changes
Reset scale to 20 of the Base2 Exponential Bucket Histogram after each collection cycle when using delta aggregation temporality.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes