[Otlp] Make sure Otlp trace and metric exporters have dedicated options instances #4200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4043
Relates to #4058
Changes
PersistentBlobProvider
being added on [metrics branch] Add configuration of persistent storage to OTLP Exporter #4121 if it is set for traces, metrics would inherit it unless it was cleared or set to something else. We could run into hard to detect and subtle bugs. To make it work nicely without needing some mechanism to "reset" options back to default, I decided to just make sure we new up a new instance when building the processor/exporter. The best fix would be to have dedicated classes (eg OtlpTraceExporterOptions & OtlpMetricExporterOptions) but hard to do without breaking things. @alanwest had the idea to introduce those and clean this up when we split up the projects.Example which works fine without this change:
Example which will be bugged without this change:
That second example depending on whether TracerProvider or MeterProvider is started first, either trace will have metricHeaders or metrics will have traceEndpoint.