Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default port for OTLP Exporter from 55680 to 4317 #1775

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

cijothomas
Copy link
Member

4317 is the default as per spec. (See open-telemetry/opentelemetry-specification#1221)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team February 2, 2021 19:56
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1775 (9937380) into main (be5efda) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1775   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files         187      187           
  Lines        5934     5934           
=======================================
  Hits         4996     4996           
  Misses        938      938           
Impacted Files Coverage Δ
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 92.30% <ø> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (ø)

@cijothomas cijothomas merged commit f77280a into main Feb 2, 2021
@cijothomas cijothomas deleted the cijothomas/otlpdefaultportfix branch February 2, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants