Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument name collisions for different Meters #2627

Closed
pirgeo opened this issue Nov 17, 2021 · 2 comments · Fixed by #2634
Closed

Instrument name collisions for different Meters #2627

pirgeo opened this issue Nov 17, 2021 · 2 comments · Fixed by #2634
Assignees
Labels
bug Something isn't working metrics Metrics signal related
Milestone

Comments

@pirgeo
Copy link
Member

pirgeo commented Nov 17, 2021

Opening this as a tracking issue for the bug where Instruments that have the same name are dropped, even if they come from separate Meters. From the API spec:

Different Meters MUST be treated as separate namespaces. The names of the Instruments under one Meter SHOULD NOT interfere with Instruments under another Meter.

This issue does only cover the fact that duplicate instrument elimination in the .NET SDK implementation does not take into account the Meter name, but only the Instrument name. It does not cover downstream implications (such as how to deal with Prometheus export in such a case, which has extensively been discussed and resolved (?) elsewhere).

While this should occur only rarely, I think its important that this is addressed. As more and more libraries adopt OpenTelemetry, such situations are likely to appear more often. OTLP is able to transport these data streams, so it seems counter-intuitive to drop them.

Additional Context:

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument

open-telemetry/opentelemetry-specification#2064
Code where instruments are dropped when using Views
Code where instruments are dropped without Views

@pirgeo
Copy link
Member Author

pirgeo commented Nov 17, 2021

Potentially relevant for #2621

@cijothomas cijothomas added the metrics Metrics signal related label Nov 17, 2021
@cijothomas cijothomas added this to the 1.2.0 milestone Nov 17, 2021
@cijothomas
Copy link
Member

Thanks! The fix would be small one, so adding to 1.2 milestone for now.
@joaopgrassi who initially raised the concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics Metrics signal related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants