Disable metric name validation for otlp format (#1669)

Author: vishweshbankwar

src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs

@@ -42,6 +42,11 @@ public GenevaMetricExporter(GenevaMetricExporterOptions options)
 
         var connectionStringBuilder = new ConnectionStringBuilder(options.ConnectionString);
 
+        if (connectionStringBuilder.DisableMetricNameValidation)
+        {
+            DisableOpenTelemetrySdkMetricNameValidation();
+        }
+
         if (connectionStringBuilder.PrivatePreviewEnableOtlpProtobufEncoding != null && connectionStringBuilder.PrivatePreviewEnableOtlpProtobufEncoding.Equals(bool.TrueString, StringComparison.OrdinalIgnoreCase))
         {
             var otlpProtobufExporter = new OtlpProtobufMetricExporter(

src/OpenTelemetry.Exporter.Geneva/Metrics/TlvMetricExporter.cs

@@ -73,11 +73,6 @@ internal TlvMetricExporter(ConnectionStringBuilder connectionStringBuilder, IRea
         {
             this.fixedPayloadStartIndex = sizeof(BinaryHeader);
         }
-
-        if (connectionStringBuilder.DisableMetricNameValidation)
-        {
-            GenevaMetricExporter.DisableOpenTelemetrySdkMetricNameValidation();
-        }
     }
 
     internal ExportResult Export(in Batch<Metric> batch)

test/OpenTelemetry.Exporter.Geneva.Tests/GenevaMetricExporterTests.cs

@@ -282,9 +282,11 @@ private void EmitMetrics(string attempt)
     }
 
     [Theory]
-    [InlineData(true)]
-    [InlineData(false)]
-    public void DisableMetricNameValidationTest(bool disableMetricNameValidation)
+    [InlineData(true, false)]
+    [InlineData(false, false)]
+    [InlineData(true, true)]
+    [InlineData(false, true)]
+    public void DisableMetricNameValidationTest(bool disableMetricNameValidation, bool enableOtlpProtobufexporter)
     {
         var instrumentNameRegexProperty = GenevaMetricExporter.GetOpenTelemetryInstrumentNameRegexProperty();
         var initialInstrumentNameRegexValue = instrumentNameRegexProperty.GetValue(null);
@@ -301,12 +303,12 @@ public void DisableMetricNameValidationTest(bool disableMetricNameValidation)
                 {
                     if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
                     {
-                        options.ConnectionString = $"Account=OTelMonitoringAccount;Namespace=OTelMetricNamespace;DisableMetricNameValidation={disableMetricNameValidation}";
+                        options.ConnectionString = $"Account=OTelMonitoringAccount;Namespace=OTelMetricNamespace;DisableMetricNameValidation={disableMetricNameValidation};PrivatePreviewOtlpProtobufMetricExporter={enableOtlpProtobufexporter}";
                     }
                     else
                     {
                         var path = GenerateTempFilePath();
-                        options.ConnectionString = $"Endpoint=unix:{path};Account=OTelMonitoringAccount;Namespace=OTelMetricNamespace;DisableMetricNameValidation={disableMetricNameValidation}";
+                        options.ConnectionString = $"Endpoint=unix:{path};Account=OTelMonitoringAccount;Namespace=OTelMetricNamespace;DisableMetricNameValidation={disableMetricNameValidation};PrivatePreviewOtlpProtobufMetricExporter={enableOtlpProtobufexporter}";
 
                         var endpoint = new UnixDomainSocketEndPoint(path);
                         server = new Socket(AddressFamily.Unix, SocketType.Stream, ProtocolType.IP);