Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span attributes to frontend #82

Merged
merged 2 commits into from
Jun 3, 2022
Merged

add span attributes to frontend #82

merged 2 commits into from
Jun 3, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Jun 2, 2022

Updates #49 to add new attributes to existing spans.

Changes

Adds attributes to frontend service spans
All handlers are wrapped with common attributes (session, request, currency, user).
Most handlers have application-specific attributes added
Defines an instr package that contains some semantic conventions

This adds some conventions (ie: app. prefix) to attribute names. We should settle on clean conventions before pushing similar instrumentation to other services.

@puckpuck puckpuck requested a review from a team June 2, 2022 02:26
@puckpuck puckpuck changed the title add manual instrumentation to frontend add span attributes to frontend Jun 2, 2022
@cartersocha
Copy link
Contributor

When I run your branch the spans look the same as the current version. Could you post a screenshot of your output?

@puckpuck
Copy link
Contributor Author

puckpuck commented Jun 3, 2022

This doesn't add spans, but rather span attributes to existing auto-instrumented spans.

Screen Shot 2022-06-02 at 9 37 04 PM

@cartersocha
Copy link
Contributor

Thanks for the pic. I was checking for attributes but had been glancing through the console output which doesn't have them for whatever reason.

LGTM

@cartersocha
Copy link
Contributor

Are you planning on documenting this in the service readme?

@puckpuck
Copy link
Contributor Author

puckpuck commented Jun 3, 2022

Are you planning on documenting this in the service readme?

That's the next PR 😉

@cartersocha cartersocha merged commit f94b269 into open-telemetry:main Jun 3, 2022
@puckpuck puckpuck deleted the puckpuck.frontend-manual-tracing branch June 3, 2022 03:18
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add manual instrumentation to frontend

* frontend span attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants