Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shipping] - add span attributes #260

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 5, 2022

Fixes #54

  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.

Changes

Previously, this service added a span event with a dynamic attribute key. I modified this code to add span attributes instead and used attribute key names in line with what other services were emitting. We don't do any auto-instrumentation in rust, so the top task of "Services extend automatic instrumentation" may actually be n/a in this case.

  • Appropriate CHANGELOG.md updated for non-trivial changes

@puckpuck puckpuck requested a review from a team August 5, 2022 00:46
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha
Copy link
Contributor

@puckpuck update the branch & Ill merge

@cartersocha cartersocha merged commit d98fe65 into open-telemetry:main Aug 5, 2022
@puckpuck puckpuck deleted the shipping-span-attributes branch August 6, 2022 00:09
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* set span attributes

* shipping span attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and enhance tracing support for shipping service (Rust)
3 participants