Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flagd UI #1725

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maindotmarcell
Copy link

@maindotmarcell maindotmarcell commented Sep 23, 2024

Changes

We're adding a user interface to the demo, through which users of the demo can update the Flagd feature flag configuration file in a more user friendly way.

Finished changes

  • Created the flagd-ui directory
    • Initialized a Next.js application
    • Created a basic view in which users can set flags in a user friendly way
    • Created an advanced view in which users can interact with the json directly from the app (includes json schema checking to ensure that the file stays valid)
    • Created a navigation bar to be able to navigate easily between the views
    • Instrumented with OpenTelemetry automatic instrumentation
    • Added Dockerfile
  • Made necessary changes to docker-compose.yaml (config file is mounted as a volume)
  • Made changes to the frontend-proxy configuration so this UI is accessible at :8080/feature

Remaining changes

  • Before merging this PR
    • Make necessary updates to the documentation
  • After merging this PR
    • Create updates for helm-charts (as discussed in the SIG call) for k8s deployment

Suggested roadmap for future contributions

  • Support for fractional targeting
  • Solution for compatibility with flagd sidecar containers for general usage (outside of the demo)

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Copy link

linux-foundation-easycla bot commented Sep 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maindotmarcell / name: Marcell Münnich (e33d518)
  • ✅ login: bornav (55cb083)

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Sep 23, 2024
@beeme1mr
Copy link
Contributor

Hey @maindotmarcell, I'm Mike from the OpenFeature team. Thanks for getting this started! Please let me know if you need our support.

By the way, I've been experimenting with a flagd compatible rule builder React component. Perhaps I could contribute to that once the initial version is live.

@maindotmarcell
Copy link
Author

Hi @beeme1mr, sounds awesome! Thanks for letting me know, we could definitely add something like a rule builder to this eventually :)

@maindotmarcell maindotmarcell marked this pull request as ready for review September 25, 2024 08:09
@maindotmarcell maindotmarcell requested a review from a team as a code owner September 25, 2024 08:09
@mviitane
Copy link
Member

Hi @maindotmarcell, there are some failing checks related to markdown-lint, sanity, and license. Could you fix those so we can proceed with the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants