Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtain pod's logs #727

Closed
jpkrohling opened this issue Feb 1, 2023 · 5 comments
Closed

Obtain pod's logs #727

jpkrohling opened this issue Feb 1, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers logging Issues relating to logging support for the demo telemetry issues that relate to the telemetry generated by the demo

Comments

@jpkrohling
Copy link
Member

I might be missing something, but apparently, the OTel Demo does not capture the logs produced by the services yet. I'm trying to get this working, and looks like we can use the collector helm chart to scrape logs from the node by using this:

opentelemetry-collector:
  mode: daemonset
  presets:
    logsCollection:
      enabled: true
      includeCollectorLogs: false

This would break traces (see open-telemetry/opentelemetry-helm-charts#623), but I'm sure we can come up with a workaround if the linked PR isn't the right solution.

My question: once the linked PR is merged, or when a similar solution is achieved, would this be an acceptable change to the demo? Or is there some other blocker that I'm not seeing?

@jpkrohling jpkrohling added the enhancement New feature or request label Feb 1, 2023
@puckpuck
Copy link
Contributor

puckpuck commented Feb 1, 2023

The demo's logs are console output from the various components and not actual OpenTelemetry logs emitted using the Otel SDKs. The use case you present to use the collector to scrape the logs from each pod was not a use case we discussed in our SIG meetings thus far. It's certainly a valid use case, and we should investigate how we would approach and enable this in the demo.

@austinlparker austinlparker added logging Issues relating to logging support for the demo telemetry issues that relate to the telemetry generated by the demo labels Feb 6, 2023
@austinlparker austinlparker added the good first issue Good for newcomers label Feb 19, 2024
@austinlparker
Copy link
Member

Since we have OpenSearch available now, this is still germane. Would love help on it!

@enesonus
Copy link

I would like to work on this issue if its still available

@puckpuck
Copy link
Contributor

We have converted several services to emit OTLP logs. We should create a new issue with a list of remaining services that need to be moved and track it from there.

@puckpuck
Copy link
Contributor

Closed this in favor of tracking via #1472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers logging Issues relating to logging support for the demo telemetry issues that relate to the telemetry generated by the demo
Projects
None yet
Development

No branches or pull requests

4 participants