Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance tracing support for admin service (PHP) #57

Closed
8 of 10 tasks
cartersocha opened this issue May 30, 2022 · 3 comments
Closed
8 of 10 tasks

Review and enhance tracing support for admin service (PHP) #57

cartersocha opened this issue May 30, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@cartersocha
Copy link
Contributor

cartersocha commented May 30, 2022

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.
  • Automatic and Manual Context Propagation are being demonstrated.
    • Interprocess context propagation is demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)

Referencing: #42

Dependent on this item: #34

@cartersocha
Copy link
Contributor Author

Tracing is code complete

@julianocosta89
Copy link
Member

@cartersocha can we close this one?
The Admin service wasn't implemented but we have PHP as a Quote Service.
I've checked all that we have done in the Quote Service already.

Automatic Instrumentation is not available for PHP: https://github.com/open-telemetry/opentelemetry-php#auto-instrumentation

The only thing missing the Baggage, is that something we want to implement here?

@cartersocha
Copy link
Contributor Author

@julianocosta89 i think we’re good for v1. I just closed out a bunch of the issues and gave you a quick heads up on slack.
Baggage would be a nice to have but not essential imo

thanks for looking through these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants