-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building protobuf assets #1374
Comments
We have a make target that will generate the protobuf assets or copy the demo.proto file for all services as required. Each language has their own way on how to do this, so instead of needing to know all of them, we created a single script that does it for all fo them.
We took this approach to allow people to make simple code changes, and then do a If you feel like there is a better way, and you developed one in your fork, I would be interested to learn more. |
Thanks! Here's the scenario I was dealing with that led to my changes
My setup makes changes to the Dockerfiles of the 4 services noted above so that a change in Further, it makes the deployment a bit more consistent. At the moment, with a change in This doesn't replace The changes in my fork can be found here. Let me know if these are sensible changes. |
I think you should submit a PR from that fork :D We will likely need some new entries in .gitignore so that people who run |
this was fixed with #1386 |
The protobuf assets for some services are in the
src
directory for that service (e.g.,src/accountingservice/genproto
) . Applying a change inpb/demo.proto
requires copying this file or usingprotoc
to generate the required files in eachsrc/Xservice
directory before invokingdocker compose build...
or similar (I think). By contrast, the other services' Dockerfiles handle the copy and build of protobuf assets.The following services (all golang) need to compile
pb/demo.proto
usingprotoc
into their respective directories beforedocker compose build...
:The following service (c++) requires copying
pb/demo.proto
tosrc/currencyservice/proto/demo.proto
Is there a reason for this? I have a fork that fixes this behavior but thought I would check first.
Use Github Discussions.
The text was updated successfully, but these errors were encountered: