Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTLP change default port number #522

Merged
merged 1 commit into from
Jan 20, 2021
Merged

OTLP change default port number #522

merged 1 commit into from
Jan 20, 2021

Conversation

TomRoSystems
Copy link
Member

@TomRoSystems TomRoSystems requested a review from a team January 19, 2021 23:31
reyang
reyang approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #522 (0884e23) into master (880e392) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         189      189           
  Lines        8388     8388           
=======================================
  Hits         7923     7923           
  Misses        465      465

@lalitb lalitb merged commit 0435edb into open-telemetry:master Jan 20, 2021
@TomRoSystems TomRoSystems mentioned this pull request Feb 11, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomRoSystems @ThomsonTan @reyang @lalitb