Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Upgrade to opentelemetry-proto 1.3.2 #2991

Merged
merged 14 commits into from
Jul 17, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jul 4, 2024

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (497eaf4) to head (4456dc8).
Report is 104 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
+ Coverage   87.12%   87.66%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5858     -251     
==========================================
- Hits         5322     5135     -187     
+ Misses        787      723      -64     

see 122 files with indirect coverage changes

@marcalff marcalff changed the title Upgrade to opentelemetry-proto 1.3.2 [BUILD] Upgrade to opentelemetry-proto 1.3.2 Jul 4, 2024
@marcalff marcalff marked this pull request as ready for review July 4, 2024 19:32
@marcalff marcalff requested a review from a team July 4, 2024 19:32
docs/maintaining-dependencies.md Show resolved Hide resolved
docs/maintaining-dependencies.md Show resolved Hide resolved
docs/maintaining-dependencies.md Show resolved Hide resolved
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Thanks for adding the upgrade steps. Few nit comments, but nothing blocking :)

@marcalff
Copy link
Member Author

Do not merge, blocked: waiting for this to settle in main:

and then will update the doc accordingly.

@marcalff marcalff added pr:do-not-merge This PR is not ready to be merged. issue:blocked Fix blocked, waiting for other fixes as prerequisites and removed issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Jul 12, 2024
@marcalff marcalff removed the pr:do-not-merge This PR is not ready to be merged. label Jul 17, 2024
@marcalff marcalff merged commit 0a43c1f into open-telemetry:main Jul 17, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants