Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Fix references in AttributeValueVisitor #2985

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

meastp
Copy link
Contributor

@meastp meastp commented Jul 2, 2024

Just a small fix - I think the correct fix is void operator()(nostd::string_view &&arg) (i.e. without const), at least if it was intended to overload the forwarding reference function above . Might also need void operator()(const nostd::string_view &arg) if both variants should be covered.

@meastp meastp requested a review from a team July 2, 2024 11:48
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (497eaf4) to head (f06d14b).
Report is 96 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5855     -254     
==========================================
- Hits         5322     5133     -189     
+ Misses        787      722      -65     
Files Coverage Δ
...ude/opentelemetry/exporters/ostream/common_utils.h 100.00% <ø> (ø)

... and 109 files with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Note that this code is only used for C++11.

@marcalff marcalff changed the title Fix references in AttributeValueVisitor [EXPORTER] Fix references in AttributeValueVisitor Jul 5, 2024
@marcalff marcalff merged commit 0ff58e8 into open-telemetry:main Jul 5, 2024
51 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jul 5, 2024
[EXPORTER] Fix references in AttributeValueVisitor (open-telemetry#2985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants