Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] ForceFlush before canceling the running requests on shutdown. #2727

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

owent
Copy link
Member

@owent owent commented Jun 29, 2024

Fixes #2715

Changes

  • ForceFlush before shutdown in OTLP exporters.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team June 29, 2024 17:46
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (497eaf4) to head (733b7a0).
Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
+ Coverage   87.12%   87.66%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5858     -251     
==========================================
- Hits         5322     5135     -187     
+ Misses        787      723      -64     

see 120 files with indirect coverage changes

@owent owent force-pushed the fixes_shutdown_in_otlp_exporter branch from 44adc77 to 0b29cc3 Compare July 1, 2024 07:25
@marcalff marcalff changed the title [WIP]ForceFlush before cancling the running requests when shutdown. [WIP] ForceFlush before canceling the running requests on shutdown. Jul 4, 2024
@owent owent changed the title [WIP] ForceFlush before canceling the running requests on shutdown. ForceFlush before canceling the running requests on shutdown. Jul 7, 2024
@marcalff marcalff self-assigned this Jul 15, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title ForceFlush before canceling the running requests on shutdown. [EXPORTER] ForceFlush before canceling the running requests on shutdown. Jul 19, 2024
@marcalff marcalff merged commit f195b9e into open-telemetry:main Jul 19, 2024
52 checks passed
@owent owent deleted the fixes_shutdown_in_otlp_exporter branch August 2, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EXPORTER] OTLP HTTP session canceled after a flush, with async export
2 participants