Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Remove OTLP HTTP support for TLS 1.0 and TLS 1.1, require TLS 1.2 #2722

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 27, 2024

Fixes #2721

Changes

Please provide a brief description of the changes here.

  • Remove support for min/max TLS 1.0 in the OTLP HTTP exporter
  • Remove support for min/max TLS 1.1 in the OTLP HTTP exporter
  • Require TLS 1.2 or better by default
  • This complies with https://www.ietf.org/rfc/rfc8996.html

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (497eaf4) to head (daa187b).
Report is 94 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5855     -254     
==========================================
- Hits         5322     5133     -189     
+ Misses        787      722      -65     

see 108 files with indirect coverage changes

@marcalff marcalff changed the title [SECURITY] Remove TLS 1.0 and TLS 1.1 [SECURITY] Remove OTLP HTTP exporter options for TLS 1.0 and TLS 1.1 Jun 27, 2024
@marcalff marcalff added removal Removal labels Jun 27, 2024
@marcalff marcalff changed the title [SECURITY] Remove OTLP HTTP exporter options for TLS 1.0 and TLS 1.1 [SECURITY] Remove OTLP HTTP support for TLS 1.0 and TLS 1.1, require TLS 1.2 Jun 27, 2024
@marcalff marcalff marked this pull request as ready for review June 27, 2024 21:12
@marcalff marcalff requested a review from a team June 27, 2024 21:12
@marcalff marcalff added the pr:please-review This PR is ready for review label Jun 27, 2024
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@marcalff marcalff merged commit 42563e4 into open-telemetry:main Jul 2, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review removal Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SECURITY] Remove OTLP HTTP support for TLS 1.0 and TLS 1.1, require TLS 1.2 or better
4 participants