Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Bump version and deps #2679

Merged
merged 26 commits into from
Jun 11, 2024
Merged

Conversation

keith
Copy link
Contributor

@keith keith commented May 23, 2024

This updates bazel as well as the deps that were required to be updated in order to support the newer version of bazel.

Fixes #2619

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (f2b60b4).
Report is 78 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 77 files with indirect coverage changes

@keith keith marked this pull request as ready for review May 23, 2024 23:28
@keith keith requested a review from a team May 23, 2024 23:28
.bazelrc Outdated Show resolved Hide resolved
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

To be honest, bazel just feel like a black whole to otel-cpp maintainers currently,
which makes it challenging to maintain, so this PR is all the more appreciated.

Please add comments about apple_support and rules_apple, it will go a very long way to help us.

bazel/repository.bzl Show resolved Hide resolved
@marcalff
Copy link
Member

Don't pay attention to CI breaks, this is a general github issue.

api/BUILD Show resolved Hide resolved
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. with nit comment on documenting the abseil requirement.

@keith
Copy link
Contributor Author

keith commented Jun 7, 2024

addressed all the comments here!

@marcalff marcalff merged commit 5089105 into open-telemetry:main Jun 11, 2024
49 checks passed
@keith
Copy link
Contributor Author

keith commented Jun 12, 2024

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to abseil 20240116.1 (Bazel only)
4 participants