[BUILD] Use nostd::enable_if_t instead of std::enable_if_t
#2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed job report error when compiling upb, which seems not a problem of this PR? |
Looks like we need to upgrade com_google_absl. Probably something changed in |
|
This PR looks ok. The build failure on MacOS seems unrelated, and to fix separately. |
lalitb
approved these changes
Apr 26, 2024
Curious on what triggered the MacOS build warning. |
My guess is that XCode update on mac-os14 (which is macos-latest) triggered clang to get updated too. |
marcalff
approved these changes
Apr 27, 2024
marcalff
changed the title
nostd::enable_if_t instead of std::enable_if_tnostd::enable_if_t instead of std::enable_if_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2647
Changes
Please provide a brief description of the changes here.
nostd::enable_if_tinstead ofstd::enable_if_tFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes