Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix variable shadow #2498

Merged
merged 1 commit into from
Jan 21, 2024
Merged

[BUILD] Fix variable shadow #2498

merged 1 commit into from
Jan 21, 2024

Conversation

owent
Copy link
Member

@owent owent commented Jan 21, 2024

Fixes #2495

Changes

  • Fix variable shadow in some old compilers.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team January 21, 2024 04:50
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b5c2b4) 87.08% compared to head (ac5d680) 87.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
+ Coverage   87.08%   87.09%   +0.02%     
==========================================
  Files         200      200              
  Lines        6103     6103              
==========================================
+ Hits         5314     5315       +1     
+ Misses        789      788       -1     
Files Coverage Δ
api/include/opentelemetry/nostd/function_ref.h 77.28% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@marcalff marcalff changed the title Fix variable shadow [BUILD] Fix variable shadow Jan 21, 2024
@marcalff marcalff merged commit ff13fdd into open-telemetry:main Jan 21, 2024
46 checks passed
@owent owent deleted the fix_2495 branch March 10, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wshadow error in function_ref.h
2 participants