Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCUMENTATION] Add api reference documentation for logs #2497

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

S-Bohn
Copy link
Contributor

@S-Bohn S-Bohn commented Jan 20, 2024

Contributes to #1695

Changes

Adds the logs directory to the doxygen file to ensure the logs api is included in the api reference

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@S-Bohn S-Bohn requested a review from a team January 20, 2024 13:49
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff13fdd) 87.09% compared to head (3dc225e) 87.09%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2497   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files         200      200           
  Lines        6103     6103           
=======================================
  Hits         5315     5315           
  Misses        788      788           

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@marcalff marcalff changed the title add api reference documentation for logs [DOCUMENTATION] Add api reference documentation for logs Jan 21, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@lalitb lalitb merged commit 02b984a into open-telemetry:main Jan 21, 2024
46 checks passed
@S-Bohn S-Bohn deleted the feat/1695/add-logs-documentation branch January 21, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants