Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Bump third_party/googletest to same version as bazel #2421

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[BUILD] Bump third_party/googletest to same version as bazel #2421

merged 2 commits into from
Dec 1, 2023

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team December 1, 2023 00:51
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 1, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bogdandrutu / name: Bogdan Drutu (a1aa303)
  • ✅ login: marcalff / name: Marc Alff (db1551f)

@bogdandrutu
Bump third_party/googletest to same version as bazel
a1aa303 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@marcalff marcalff changed the title Bump third_party/googletest to same version as bazel [BUILD] Bump third_party/googletest to same version as bazel Dec 1, 2023
marcalff
marcalff approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2421 (db1551f) into main (27a58cd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2421   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6079     6079           
=======================================
  Hits         5292     5292           
  Misses        787      787

@marcalff marcalff merged commit 25343e6 into open-telemetry:main Dec 1, 2023
45 checks passed
@bogdandrutu bogdandrutu deleted the fixgoogletest branch December 1, 2023 20:03
@Porkepix Porkepix mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @lalitb @marcalff