Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADMIN] Add file .github/repository-settings.md #2392

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 3, 2023

Changes

Add file .github/repository-settings.md, to comply with community processes.

See the file content for details.

@marcalff
Copy link
Member Author

marcalff commented Nov 3, 2023

@ThomsonTan @lalitb @esigo

Please confirm you have the admin privilege now (github UI contains the required / not required builds in branch protection rules).

Please approve the PR, to acknowledge you are aware of this new file.

For those who remember, CI broke loose all other the place last year around this period, due to a platform upgrade for the ubuntu image.

At least if the same happens again, now we have more tools to handle this, and push critical fixes if needed, even under degraded conditions.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2392 (faeb33a) into main (5bf2f80) will not change coverage.
The diff coverage is n/a.

❗ Current head faeb33a differs from pull request most recent head 42a5486. Consider uploading reports for the commit 42a5486 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         199      199           
  Lines        6030     6030           
=======================================
  Hits         5272     5272           
  Misses        758      758           

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@ThomsonTan ThomsonTan merged commit 35a9362 into open-telemetry:main Nov 6, 2023
44 checks passed
@marcalff marcalff deleted the add_repository_settings branch June 3, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants