-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow extension of the lifetime of ContextStorage. #1214
allow extension of the lifetime of ContextStorage. #1214
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 196 196
Lines 7038 7038
=======================================
Hits 6544 6544
Misses 494 494
|
Could we provide some dedicated helper method to increase the lifetime of RuntimeStorage? As the user cannot deduce the purpose of this API directly from the API name. |
Could you please elaborate? |
I meant some explicit API like |
Fixes #1211 (issue)
Changes
The specifications require the context to be immutable, but does not talk about whether the users are allowed to have access to the storage.
The change in this PR allows the users to get a shared_ptr to const so they can't do anything with the pointer but extending the lifetime of the storage.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes