Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage <-> Context interaction on Baggage as static methods? #961

Closed
jsuereth opened this issue Aug 25, 2021 · 0 comments · Fixed by #963
Closed

Baggage <-> Context interaction on Baggage as static methods? #961

jsuereth opened this issue Aug 25, 2021 · 0 comments · Fixed by #963
Labels
enhancement New feature or request spec-compliance Not compliant to OpenTelemetry specs

Comments

@jsuereth
Copy link
Contributor

The Specificaiton states that baggage should have convenience methods to go to/from context.

Currently, that resides in the propagation module of Bagage,

However, given that interacting with baggage is not just a component of propagation and how most SDKs provide To/From context methods directly on baggage (or at least in the same package/header), I suggest Baggage should have static to/from context methods (or a header file within the baggage directory that provide this functionality.

Effectively, let's not conflate using Baggage with propagation of baggage.

@jsuereth jsuereth added enhancement New feature or request spec-compliance Not compliant to OpenTelemetry specs labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant