Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultTracer in API headers should be marked internal / not-for-public use or documented #949

Closed
jsuereth opened this issue Aug 15, 2021 · 0 comments
Closed

DefaultTracer in API headers should be marked internal / not-for-public use or documented #949

jsuereth opened this issue Aug 15, 2021 · 0 comments
Assignees
@lalitb

Comments

@jsuereth
Copy link
Contributor

jsuereth commented Aug 15, 2021 •
edited
Loading

Wasn't clear what this was used for on first inspection. Either it needs to be documented in its use or move them to an internal / not-public-looking namespace.

Additionally, if this is meant to fill this portion of the spec, then there should be a DefaultTracerProvider which is a Noop as well.
@jsuereth jsuereth mentioned this issue Aug 15, 2021
Closed
13 tasks
@jsuereth jsuereth changed the title DefaultSpan + DefaultTracer in API headers should be marked internal / not-for-public use or documented DefaultTracer in API headers should be marked internal / not-for-public use or documented Aug 19, 2021
@lalitb lalitb mentioned this issue Aug 24, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsuereth @ThomsonTan @lalitb